fix: ignore host when comparing role grants #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please create a test that verifies this was solved? It would be in My point is to have a regression test, that fails with the old implementation and is fixed by this change. That way, we would avoid this issue from repeating. |
|
@petoju Sure, I will work on that. |
|
@petoju Added a test for this 👍 |
petoju
approved these changes
Jan 13, 2025
|
Thanks, this looks good! |
|
Released in 3.0.69. Note that this may contain issues like 3.0.68, that were reported in #189 - nothing was done about them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #169 (comment). Tested locally and confirmed that the roles are granted successfully and the state inconsistency is resolved!